Migrate mixed optimizer to OSS #2573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 14, 2024
Summary: Pull Request resolved: pytorch#2573 Differential Revision: D64349675
saitcakmak
force-pushed
the
export-D64349675
branch
from
2e2953e
to
7712ec4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2573 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 195 196 +1
Lines 17122 17333 +211
========================================
+ Hits 17119 17330 +211
Misses 3 3 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
saitcakmak
force-pushed
the
export-D64349675
branch
from
7712ec4
to
ef46a1d
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 15, 2024
Summary: Pull Request resolved: pytorch#2573 Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed. Differential Revision: D64349675
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
saitcakmak
force-pushed
the
export-D64349675
branch
from
ef46a1d
to
9dde269
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 15, 2024
Summary: Pull Request resolved: pytorch#2573 Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed. Differential Revision: D64349675
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
saitcakmak
force-pushed
the
export-D64349675
branch
from
9dde269
to
a23151a
Compare
…oad the correct commit data. Differential Revision: D64348157
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Oct 15, 2024
Summary: Pull Request resolved: pytorch#2573 Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed. Reviewed By: Balandat Differential Revision: D64349675
saitcakmak
force-pushed
the
export-D64349675
branch
from
a23151a
to
76b3c6f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
Summary: Pull Request resolved: pytorch#2573 Moves `optimize_acqf_mixed_alternating` to OSS BoTorch. This is an optimizer designed for mixed (low-cardinality) integer and continuous variables. It alternates between discrete and continuous optimization steps to optimize the acquisition function. The discrete step greedily searches over the integer variables, moving to the 1-Manhattan distance neighbor that offers the greatest improvement at each step. The continuous steps calls to `optimize_acqf` to optimize the continuous variables, while keeping the discrete dimensions fixed. Reviewed By: Balandat Differential Revision: D64349675
|
This pull request was exported from Phabricator. Differential Revision: D64349675 |
saitcakmak
force-pushed
the
export-D64349675
branch
from
76b3c6f
to
343228e
Compare
|
This pull request has been merged in fb0c667. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64349675