Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to optimizer initializers #2570

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary:

  • Simplified a mini-batch evaluation step, which seemed quite complex when done manually.
  • Updated a few type hints.
  • Added stacklevel arg to some warnings.

Differential Revision: D64267268

Summary:
- Simplified a mini-batch evaluation step, which seemed quite complex when done manually.
- Updated a few type hints.
- Added stacklevel arg to some warnings.

Differential Revision: D64267268
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64267268

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (c48db81) to head (b523da5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   99.98%   99.98%   -0.01%     
==========================================
  Files         195      195              
  Lines       17122    17116       -6     
==========================================
- Hits        17119    17113       -6     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 85d8996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants