Speed up slow input constructor test #2564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63838676 |
esantorella
added a commit
to esantorella/botorch
that referenced
this pull request
Oct 3, 2024
Summary: Pull Request resolved: pytorch#2564 Differential Revision: D63838676
esantorella
force-pushed
the
export-D63838676
branch
from
3a181d8
to
34776f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63838676 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 195 +2
Lines 17071 17112 +41
=======================================
+ Hits 17068 17109 +41
Misses 3 3 ☔ View full report in Codecov by Sentry. |
…h#2563) Summary: Context: Many BoTorch tests take a while because they run optimization code. But it's good that this code runs rather than being avoided or mocked out, becuase the tests are ensuring that things work end-to-end. Borrowing a page from Ax's `fast_botorch_optimize`, this commit introduces the same thing to BoTorch, with the exception of `fit_fully_bayesian_model_nuts`. A future commit to Ax can remove that functionality from Ax in favor of importing it from BoTorch, but we might not want to do it right way because then Ax won't work with older versions of BoTorch. This PR: * Introduces `fast_optimize`, which is the same as Ax's `fast_botorch_optimize`, but with different import paths. * Applies it to a slow test, reducing runtime to 2s from 6s-10s. Reviewed By: sdaulton Differential Revision: D63838626
Summary: Pull Request resolved: pytorch#2564 Reviewed By: sdaulton Differential Revision: D63838676
esantorella
force-pushed
the
export-D63838676
branch
from
34776f7
to
e4217cd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63838676 |
|
This pull request has been merged in c7b3d82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D63838676