Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input constructor for qMultiFidelityKnowledgeGradient #2519

Closed
wants to merge 1 commit into from

Commits on Sep 9, 2024

  1. Fix input constructor for qMultiFidelityKnowledgeGradient (pytorch#…

    …2519)
    
    Summary:
    Pull Request resolved: pytorch#2519
    
    The input constructor for `qMultiFidelityKnowledgeGradient` was computing `current_value` in a manner that was effectively not fidelity-aware (the fidelity dimension was not fixed in the optimization done to obtain `current_value`), since it was simply re-using functionality from the input constructor for `construct_inputs_qKG`.
    
    This diff addresses this by making use of `target_fidelities` as the `fixed_features` argument to `D62380369`.
    
    Differential Revision: D62391106
    ltiao authored and facebook-github-bot committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a7dff50 View commit details
    Browse the repository at this point in the history