Silence input data warnings in tests #2508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62200731 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 4, 2024
Summary: X-link: pytorch/botorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Differential Revision: D62200731
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 16949 16949
=======================================
Hits 16947 16947
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Summary: X-link: facebook/Ax#2739 Pull Request resolved: pytorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Reviewed By: Balandat, esantorella Differential Revision: D62200731
|
This pull request was exported from Phabricator. Differential Revision: D62200731 |
saitcakmak
force-pushed
the
export-D62200731
branch
from
9b03c5c
to
944a0f6
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: facebook#2739 X-link: pytorch/botorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Reviewed By: Balandat, esantorella Differential Revision: D62200731
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 5, 2024
Summary: X-link: facebook/Ax#2739 Pull Request resolved: pytorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Differential Revision: D62200731 Reviewed By: Balandat, esantorella
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: facebook#2739 X-link: pytorch/botorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Differential Revision: D62200731 Reviewed By: Balandat, esantorella
|
This pull request has been merged in 3db1a0e. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Sep 5, 2024
Summary: Pull Request resolved: #2739 X-link: pytorch/botorch#2508 This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again. Reviewed By: Balandat, esantorella Differential Revision: D62200731 fbshipit-source-id: a8c802abc613e0b144c6eb817f4692857a4cb83d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This logic broke since D61797434 updated the warning messages, leading to too many of these warnings in test outputs again.
Differential Revision: D62200731