Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise exception if X_pending is set on underlying AF in prior-guided AF #2505

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Sep 3, 2024

Summary: See title. And discussion in #2493.

Reviewed By: saitcakmak

Differential Revision: D62143198

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62143198

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (c47c01c) to head (258ac76).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2505   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         193      193           
  Lines       16946    16949    +3     
=======================================
+ Hits        16944    16947    +3     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…AF (pytorch#2505)

Summary:
Pull Request resolved: pytorch#2505

See title. And discussion in pytorch#2493.

Reviewed By: saitcakmak

Differential Revision: D62143198
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62143198

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6b5759b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants