Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compare_mc_analytic_acquisition tutorial to use LogEI #2498

Closed
wants to merge 3 commits into from

Conversation

SebastianAment
Copy link
Contributor

Summary: Updating the analytic vs MC comparison tutorial to use LogEI.

Differential Revision: D61997650

Differential Revision: D61997651
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997650

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (0b4942e) to head (cb16d6c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2498   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         193      193           
  Lines       16947    16947           
=======================================
  Hits        16945    16945           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:
Pull Request resolved: pytorch#2496

Updating the constrained noisy optimization tutorial to use LogEI, which improves the performance of both versions, and crystalizes the advantage of the `qLogNEI` in the noisy context:

Before:
{F1834686039}

After:
{F1834684434}

Differential Revision: D61997649

Reviewed By: esantorella
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…ch#2498)

Summary:
Pull Request resolved: pytorch#2498

Updating the analytic vs MC comparison tutorial to use LogEI.

Reviewed By: esantorella

Differential Revision: D61997650
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997650

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997650

SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…ch#2498)

Summary:
Pull Request resolved: pytorch#2498

Updating the analytic vs MC comparison tutorial to use LogEI.

Reviewed By: esantorella

Differential Revision: D61997650
…ch#2498)

Summary:
Pull Request resolved: pytorch#2498

Updating the analytic vs MC comparison tutorial to use LogEI.

Reviewed By: esantorella

Differential Revision: D61997650
SebastianAment added a commit to SebastianAment/botorch that referenced this pull request Aug 29, 2024
…ch#2498)

Summary:
Pull Request resolved: pytorch#2498

Updating the analytic vs MC comparison tutorial to use LogEI.

Differential Revision: D61997650

Reviewed By: esantorella
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61997650

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 37f69c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants