Bug: Enable SaasPyroModel to sample from prior #2465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: With no observations, FBGPs should still be able to fit the model by sampling from the prior. This solution allows that to happen through fit_fully_bayesian_model_nuts. Note that this is much slower (almost instant vs. NUTS) than simply sampling from the individual priors, but keeps a consistent interface. Reviewed By: saitcakmak Differential Revision: D61145689
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61145689 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 191 191
Lines 16823 16824 +1
=======================================
+ Hits 16821 16822 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in a7be6cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With no observations, FBGPs should still be able to fit the model by sampling from the prior. This solution allows that to happen through fit_fully_bayesian_model_nuts.
Note that this is much slower (almost instant vs. NUTS) than simply sampling from the individual priors, but keeps a consistent interface.
Reviewed By: saitcakmak
Differential Revision: D61145689