Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up SAASBO tutorial by reducing dimension in smoke-test mode #2463

Closed
wants to merge 1 commit into from

Conversation

esantorella
Copy link
Member

Summary:
Context: This was taking too long to run.

This PR:

  • Uses a 2d problem in smoke-test mode, cutting the runtime each of the two slowest cells by ~50%
  • Uses LogEI instead of EI, getting rid of a warning

Differential Revision: D61083720

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61083720

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (bcdea09) to head (5ccb64d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         191      191           
  Lines       16823    16823           
=======================================
  Hits        16821    16821           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61083720

esantorella added a commit to esantorella/botorch that referenced this pull request Aug 11, 2024
…torch#2463)

Summary:
Pull Request resolved: pytorch#2463

Context: This was taking too long to run.

This PR:
* Uses a 2d problem in smoke-test mode, cutting the runtime each of the two slowest cells by ~50%
* Uses LogEI instead of EI, getting rid of a warning

Differential Revision: D61083720
…torch#2463)

Summary:
Pull Request resolved: pytorch#2463

Context: This was taking too long to run.

This PR:
* Uses a 2d problem in smoke-test mode, cutting the runtime each of the two slowest cells by ~50%
* Uses LogEI instead of EI, getting rid of a warning

Differential Revision: D61083720
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61083720

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f4c2915.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants