Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: FixedFeatureAcquisitionFunction should not convert floats to float32 tensors #1944

Closed
wants to merge 1 commit into from

Conversation

esantorella
Copy link
Member

Motivation

Addresses #1943

  • Dtype fix: floats should be double-precision
  • Cleanup for clarity
  • Units

Test Plan

Added unit tests

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 24, 2023
@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1944 (0fdbe04) into main (81f7c98) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0fdbe04 differs from pull request most recent head a5946e3. Consider uploading reports for the commit a5946e3 to get more accurate results

@@           Coverage Diff           @@
##             main    #1944   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         177      177           
  Lines       15676    15683    +7     
=======================================
+ Hits        15668    15675    +7     
  Misses          8        8           
Impacted Files Coverage Δ
botorch/acquisition/fixed_feature.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link
Contributor

@esantorella merged this pull request in 71fd34e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants