Add RoBERTa to the model suite #2279
Conversation
|
Hi @Rohanjames1997! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Rohanjames1997
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Rohanjames1997
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
The PR looks good. Do you mind to rebase on the latest main branch and push again? |
|
Thanks for the review @xuzhao9 ! I've rebased it. |
Rohanjames1997
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Rohanjames1997
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 can you merge it too? I'm not authorized, it seems. |
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Rohanjames1997 The PR has landed. Thanks for your contribution! |
I'm adding sam2 to TorchBench pytorch/benchmark#2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is pytorch/benchmark#2584 The main thing to call out that the newer transformers added by pytorch/benchmark#2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by pytorch/benchmark#2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 Pull Request resolved: #145455 Approved by: https://github.com/kit1980
Summary: I'm adding sam2 to TorchBench #2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is #2584 The main thing to call out that the newer transformers added by #2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by #2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 X-link: pytorch/pytorch#145455 Approved by: https://github.com/kit1980 Reviewed By: ZainRizvi Differential Revision: D69056903 fbshipit-source-id: 6b98c246b9dc8811257ec46d4821ba6ee3363dfe
I'm adding sam2 to TorchBench pytorch/benchmark#2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is pytorch/benchmark#2584 The main thing to call out that the newer transformers added by pytorch/benchmark#2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by pytorch/benchmark#2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 Pull Request resolved: pytorch#145455 Approved by: https://github.com/kit1980
I'm adding sam2 to TorchBench pytorch/benchmark#2566, so, as part of that, I'm updating PyTorch CI to use latest TorchBench commit. The corresponding change from TorchBench is pytorch/benchmark#2584 The main thing to call out that the newer transformers added by pytorch/benchmark#2488 is regressing several models. This needs to be investigated further, and I pin the version to unblock this change. * `hf_Roberta_base` a new model added by pytorch/benchmark#2279, not sure why it fails accuracy on A10G, but it works fine on A100 * `speech_transformer` failures are pre-existing trunk failures, i.e. https://github.com/pytorch/pytorch/actions/runs/13040114684/job/36380989702#step:22:2408 Pull Request resolved: pytorch#145455 Approved by: https://github.com/kit1980
https://huggingface.co/FacebookAI/xlm-roberta-base