[tritonbench] Report tflops by default for gemm; fix exception handling #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: TFLOPS is the core metric for gemm. Along the way I hit some bugs and weirdness: - You couldn't Ctrl-C out of tritonbench, because the `finally` clause contained a return, which [suppresses the exception](https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions) - In generally I don't think the framework should catch RuntimeErrors, it makes it really hard to debug stuff because the desired result just ends up missing - In fact we had a typo (`metric` instead of `metrics` in the framework code that was never caught because it was caught and suppressed Test Plan: ``` python run_benchmark.py triton --op gemm --splitk ```
|
@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bertmaher merged this pull request in 8a8c1fc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: TFLOPS is the core metric for gemm. Along the way I hit some bugs and weirdness:
finallyclause contained a return, which suppresses the exceptionmetricinstead ofmetricsin the framework code that was never caught because it was caught and suppressedTest Plan: