Windows fixes

[aaron-boxer]

This PR contains a few small fixes to allow setup to run on Windows without erroring out.

[facebook-github-bot]

Hi @aaron-boxer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[msaroufim]

Assuming CI passes this should be fine to merge, just triggered it now

[DiweiSun]

Regarding to the os.remove part in init.py, I suppose the temp file cannot be deleted since the file descriptor is not closed yet. Can we try with the following:

   fd, stdout_fpath = tempfile.mkstemp()

    try:
        output_buffer = io.FileIO(stdout_fpath, mode="w")
    except Exception as e:
        return (False, e, io.FileIO(stdout_fpath, mode="r").read().decode())
    finally:
        output_buffer.close()
        del output_buffer
        os.close(fd)
        os.remove(stdout_fpath)

[aaron-boxer]

Regarding to the os.remove part in init.py, I suppose the temp file cannot be deleted since the file descriptor is not closed yet. Can we try with the following:

   fd, stdout_fpath = tempfile.mkstemp()

    try:
        output_buffer = io.FileIO(stdout_fpath, mode="w")
    except Exception as e:
        return (False, e, io.FileIO(stdout_fpath, mode="r").read().decode())
    finally:
        output_buffer.close()
        del output_buffer
        os.close(fd)
        os.remove(stdout_fpath)

Thanks, that worked - this is a much better fix.

[boxerab]

Assuming CI passes this should be fine to merge, just triggered it now

CI passing now, ready to merge !

[xuzhao9]

LGTM, thanks for fixing it on Windows!

[facebook-github-bot]

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@xuzhao9 merged this pull request in 254c5a7.