Skip to content

infra: Enabling aarch64 builds #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

infra: Enabling aarch64 builds #3470

wants to merge 1 commit into from

Conversation

narendasan
Copy link
Collaborator

Description

Enables CI builds and testing for aarch64 + CUDA

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 22:30:14.755034+00:00
+++ /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 22:30:34.104714+00:00
@@ -23,12 +23,16 @@
        raise Exception("--matrix needs to be provided")
    matrix_dict = json.loads(options.matrix)
    includes = matrix_dict["include"]
    filtered_includes = []
    for item in includes:
-        if all([item["python_version"] not in disabled_python_versions,
-                item["desired_cuda"] != cpu_tag]):
+        if all(
+            [
+                item["python_version"] not in disabled_python_versions,
+                item["desired_cuda"] != cpu_tag,
+            ]
+        ):
            filtered_includes.append(item)
    filtered_matrix_dict = {}
    filtered_matrix_dict["include"] = filtered_includes
    print(json.dumps(filtered_matrix_dict))

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 22:39:43.675826+00:00
+++ /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 22:40:05.935304+00:00
@@ -23,12 +23,16 @@
        raise Exception("--matrix needs to be provided")
    matrix_dict = json.loads(options.matrix)
    includes = matrix_dict["include"]
    filtered_includes = []
    for item in includes:
-        if all([item["python_version"] not in disabled_python_versions,
-                item["desired_cuda"] != cpu_tag]):
+        if all(
+            [
+                item["python_version"] not in disabled_python_versions,
+                item["desired_cuda"] != cpu_tag,
+            ]
+        ):
            filtered_includes.append(item)
    filtered_matrix_dict = {}
    filtered_matrix_dict["include"] = filtered_includes
    print(json.dumps(filtered_matrix_dict))

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 23:20:46.104188+00:00
+++ /home/runner/work/TensorRT/TensorRT/.github/scripts/filter-matrix.py	2025-04-11 23:21:06.487257+00:00
@@ -24,12 +24,16 @@
        raise Exception("--matrix needs to be provided")
    matrix_dict = json.loads(options.matrix)
    includes = matrix_dict["include"]
    filtered_includes = []
    for item in includes:
-        if all([item["python_version"] not in disabled_python_versions,
-                item["desired_cuda"] != cpu_tag]):
+        if all(
+            [
+                item["python_version"] not in disabled_python_versions,
+                item["desired_cuda"] != cpu_tag,
+            ]
+        ):
            filtered_includes.append(item)
    filtered_matrix_dict = {}
    filtered_matrix_dict["include"] = filtered_includes
    print(json.dumps(filtered_matrix_dict))

@narendasan narendasan closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants