-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry-pick NGC fixes for 25.02 #3371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/noxfile.py 2025-01-30 00:32:10.754645+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py 2025-01-30 00:32:31.244772+00:00
@@ -235,11 +235,13 @@
session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
num_workers = "auto"
tests = ["lowering"]
for test in tests:
if USE_HOST_DEPS:
- session.run_always("pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH})
+ session.run_always(
+ "pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH}
+ )
else:
session.run_always("pytest", test, "-n", num_workers)
def run_dynamo_partitioning_tests(session):
--- /home/runner/work/TensorRT/TensorRT/setup.py 2025-01-30 00:32:10.772645+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py 2025-01-30 00:32:35.504450+00:00
@@ -31,11 +31,11 @@
LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")
def get_root_dir() -> Path:
- dir_path = os.path.dirname(os.path.realpath(__file__))
+ dir_path = os.path.dirname(os.path.realpath(__file__))
return dir_path
def get_git_revision_short_hash() -> str:
return (
@@ -115,11 +115,10 @@
if release_env_var == "1":
RELEASE = True
if (gpu_arch_version := os.environ.get("CU_VERSION")) is None:
gpu_arch_version = f"cu{__cuda_version__.replace('.','')}"
-
__version__ = os.environ.get("BUILD_VERSION")
if "--ci" in sys.argv:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/noxfile.py 2025-01-30 00:55:20.850235+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py 2025-01-30 00:55:43.182835+00:00
@@ -235,11 +235,13 @@
session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
num_workers = "auto"
tests = ["lowering"]
for test in tests:
if USE_HOST_DEPS:
- session.run_always("pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH})
+ session.run_always(
+ "pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH}
+ )
else:
session.run_always("pytest", test, "-n", num_workers)
def run_dynamo_partitioning_tests(session):
--- /home/runner/work/TensorRT/TensorRT/setup.py 2025-01-30 00:55:20.869235+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py 2025-01-30 00:55:47.440807+00:00
@@ -31,11 +31,11 @@
LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")
def get_root_dir() -> Path:
- dir_path = os.path.dirname(os.path.realpath(__file__))
+ dir_path = os.path.dirname(os.path.realpath(__file__))
return dir_path
def get_git_revision_short_hash() -> str:
return (
@@ -115,11 +115,10 @@
if release_env_var == "1":
RELEASE = True
if (gpu_arch_version := os.environ.get("CU_VERSION")) is None:
gpu_arch_version = f"cu{__cuda_version__.replace('.','')}"
-
__version__ = os.environ.get("BUILD_VERSION")
if "--ci" in sys.argv:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla signed
component: api [Python]
Issues re: Python API
component: build system
Issues re: Build system
component: conversion
Issues re: Conversion stage
component: converters
Issues re: Specific op converters
component: core
Issues re: The core compiler
component: dynamo
Issues relating to the `torch.compile` or `torch._dynamo.export` paths
component: fx
component: runtime
component: tests
Issues re: Tests
documentation
Improvements or additions to documentation
fx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: