Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick NGC fixes for 25.02 #3371

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Jan 30, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044 peri044 changed the title Ngc fixes 25.02 chore: Ngc fixes 25.02 Jan 30, 2025
@peri044 peri044 changed the title chore: Ngc fixes 25.02 chore: cherry-pick NGC fixes for 25.02 Jan 30, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: fx component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 30, 2025
@github-actions github-actions bot requested a review from narendasan January 30, 2025 00:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2025-01-30 00:32:10.754645+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2025-01-30 00:32:31.244772+00:00
@@ -235,11 +235,13 @@
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
    num_workers = "auto"
    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("pytest", test, "-n", num_workers)


def run_dynamo_partitioning_tests(session):
--- /home/runner/work/TensorRT/TensorRT/setup.py	2025-01-30 00:32:10.772645+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py	2025-01-30 00:32:35.504450+00:00
@@ -31,11 +31,11 @@

LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")


def get_root_dir() -> Path:
-    dir_path = os.path.dirname(os.path.realpath(__file__)) 
+    dir_path = os.path.dirname(os.path.realpath(__file__))
    return dir_path


def get_git_revision_short_hash() -> str:
    return (
@@ -115,11 +115,10 @@
    if release_env_var == "1":
        RELEASE = True

if (gpu_arch_version := os.environ.get("CU_VERSION")) is None:
    gpu_arch_version = f"cu{__cuda_version__.replace('.','')}"
-


__version__ = os.environ.get("BUILD_VERSION")

if "--ci" in sys.argv:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2025-01-30 00:55:20.850235+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2025-01-30 00:55:43.182835+00:00
@@ -235,11 +235,13 @@
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
    num_workers = "auto"
    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "pytest", test, "-n", num_workers, env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("pytest", test, "-n", num_workers)


def run_dynamo_partitioning_tests(session):
--- /home/runner/work/TensorRT/TensorRT/setup.py	2025-01-30 00:55:20.869235+00:00
+++ /home/runner/work/TensorRT/TensorRT/setup.py	2025-01-30 00:55:47.440807+00:00
@@ -31,11 +31,11 @@

LEGACY_BASE_VERSION_SUFFIX_PATTERN = re.compile("a0$")


def get_root_dir() -> Path:
-    dir_path = os.path.dirname(os.path.realpath(__file__)) 
+    dir_path = os.path.dirname(os.path.realpath(__file__))
    return dir_path


def get_git_revision_short_hash() -> str:
    return (
@@ -115,11 +115,10 @@
    if release_env_var == "1":
        RELEASE = True

if (gpu_arch_version := os.environ.get("CU_VERSION")) is None:
    gpu_arch_version = f"cu{__cuda_version__.replace('.','')}"
-


__version__ = os.environ.get("BUILD_VERSION")

if "--ci" in sys.argv:

@peri044 peri044 merged commit e3141ed into release/ngc/25.02 Jan 30, 2025
24 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: fx component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation fx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants