Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI docker build error for release 2.6 #3360

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix: CI docker build error for release 2.6 #3360

merged 1 commit into from
Jan 18, 2025

Conversation

zewenli98
Copy link
Collaborator

Description

Fix CI docker build error for release 2.6.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 17, 2025
@zewenli98 zewenli98 force-pushed the fix_docker_build_for_release2.6 branch from cd1882d to b6fdb72 Compare January 17, 2025 21:43
peri044
peri044 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 2.6

@zewenli98 zewenli98 merged commit ff44947 into release/2.6 Jan 18, 2025
77 checks passed
peri044 pushed a commit that referenced this pull request Jan 30, 2025
@zewenli98 @peri044
fix: CI docker build error for release 2.6 (#3360)
7b93e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@lanluo-nvidia lanluo-nvidia Awaiting requested review from lanluo-nvidia

Assignees

@zewenli98 zewenli98

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewenli98 @peri044 @facebook-github-bot