Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add save API for torch-trt compiled models #2691

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat: Add save API for torch-trt compiled models #2691

merged 1 commit into from
Mar 26, 2024
+311 −261

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Mar 14, 2024

Description

Add save API for torch-trt compiled models

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Sorry, something went wrong.

@github-actions github-actions bot added component: tests Issues re: Tests component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 14, 2024
@github-actions github-actions bot requested a review from narendasan March 14, 2024 09:02
@github-actions github-actions bot added component: core Issues re: The core compiler component: runtime labels Mar 18, 2024
@peri044 peri044 changed the base branch from main to release/2.3 March 19, 2024 21:41
@peri044 peri044 requested a review from gs-olive March 20, 2024 02:58
gs-olive
gs-olive reviewed Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Added some small comments

@peri044 peri044 mentioned this pull request Mar 22, 2024
Merged
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 25, 2024
gs-olive
gs-olive reviewed Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great - added a few small comments

@peri044
parent f39e89e
Loading
Loading status checks…
982dbd2 
author Dheeraj Peri <[email protected]> 1711393059 -0700
committer Dheeraj Peri <[email protected]> 1711393072 -0700

chore: minor updates

chore: Fix save failures

chore: minor fixes

chore: remove duplicate bert test case

chore: remove comments

chore: add load api

chore: minor updates

chore: minor updates

chore: minor updates

chore: more updates
@peri044 peri044 merged commit bb7592f into release/2.3 Mar 26, 2024
26 of 27 checks passed
@peri044 peri044 mentioned this pull request Mar 27, 2024
Merged
7 tasks
zewenli98 pushed a commit that referenced this pull request Apr 26, 2024
@peri044 @zewenli98
feat: Add save API for torch-trt compiled models (#2691)
b6a9c71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive

@narendasan narendasan

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peri044 @gs-olive @facebook-github-bot