re-enable interleaved 1f1b test #1079
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Huang
added a commit
that referenced
this pull request
Apr 22, 2024
ghstack-source-id: 4a8c1cc4471dc9615d2430080b3b392bfacbb84f Pull Request resolved: #1079
kwen2501
reviewed
Apr 22, 2024
| ) | ||
| schedule.step_microbatches(microbatches) | ||
| schedule.step_microbatches(microbatches, target_mbs=target_mbs) |
There was a problem hiding this comment.
Should we feed target to every rank?
There was a problem hiding this comment.
we don't have to, but if we do that is also allright too since if it is not the last stage then it wont calculate the loss using the target_mbs.
There was a problem hiding this comment.
I'd rather not rely on assumptions :)
We should test the real case (strictly speaking even microbatches should not be fed to every rank).
| torch.randn_like(microbatch) for _ in range(num_microbatches) | ||
| ] | ||
| schedule.step_microbatches(microbatches) | ||
| schedule.step_microbatches(microbatches, target_mbs=target_mbs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):