Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating split_table_batched_embeddings_ops_training.py #3613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating split_table_batched_embeddings_ops_training.py #3613

wants to merge 1 commit into from

Conversation

basilwong
Copy link

Summary:
After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit bcfc103
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/679c28ec7d86c90009724a85
😎 Deploy Preview https://deploy-preview-3613--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

facebook-github-bot pushed a commit that referenced this pull request Jan 24, 2025
@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
d1a15ae 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

19 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

facebook-github-bot pushed a commit that referenced this pull request Jan 27, 2025
@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
f74a1ea 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

facebook-github-bot pushed a commit that referenced this pull request Jan 27, 2025
@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
5dce40c 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Reviewed By: q10

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

5 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

facebook-github-bot pushed a commit that referenced this pull request Jan 29, 2025
@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
50febbe 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Reviewed By: q10

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

facebook-github-bot pushed a commit that referenced this pull request Jan 30, 2025
@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
4d89cd4 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Reviewed By: q10

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

@basilwong @facebook-github-bot
Updating split_table_batched_embeddings_ops_training.py (#3613)
bcfc103 
Summary:
X-link: facebookresearch/FBGEMM#690


After this diff stack:

EmbeddingKernelConfig now supports adding embedding_table_int32_index_type and embedding_table_int32_offset_type to the fused_params.

These are used downstream to determine whether the indices and offsets types for split_table_batched_embeddings_ops_training.py

Reviewed By: q10

Differential Revision: D68005929
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68005929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basilwong @facebook-github-bot