Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and fixes to tensor_accessor.h #3571

Closed
wants to merge 1 commit into from
Closed

Conversation

q10
Copy link
Contributor

@q10 q10 commented Jan 14, 2025

Summary:

  • Fix TensorAccessorBase constructor to work with empty tensors, which are used in FBGEMM code

  • Add better logging for errors

Differential Revision: D68048640

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit bda68ef
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/679139a77ce5ec00087eb702
😎 Deploy Preview https://deploy-preview-3571--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D68048640 branch from 72b70b2 to 3fceb73 Compare January 14, 2025 21:36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@q10 q10 force-pushed the export-D68048640 branch from 3fceb73 to 736737e Compare January 14, 2025 23:05
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

@q10 q10 force-pushed the export-D68048640 branch from 736737e to 3782065 Compare January 15, 2025 07:20
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

@q10 q10 force-pushed the export-D68048640 branch from 3782065 to 2568956 Compare January 15, 2025 08:21
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

@q10 q10 force-pushed the export-D68048640 branch from 2568956 to 2b155a3 Compare January 15, 2025 18:16
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
@q10 q10 force-pushed the export-D68048640 branch from 2b155a3 to 324029c Compare January 21, 2025 22:07
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
@q10 q10 force-pushed the export-D68048640 branch from 324029c to bda68ef Compare January 22, 2025 18:32
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68048640

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 22, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 22, 2025
Summary:

X-link: facebookresearch/FBGEMM#656

- Fix `TensorAccessorBase` constructor to work with empty tensors, which are used in FBGEMM code

- Add better logging for errors

Reviewed By: basilwong

Differential Revision: D68048640
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4df8a12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants