New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch D66310520 to make it build in OSS #3409

Open

q10 wants to merge 2 commits into pytorch:main from q10:export-D66399304

Contributor

q10 commented Nov 23, 2024

Summary: - Patch D66310520 to make the code build in OSS

Differential Revision: D66399304

facebook-github-bot added cla signed module: rocm labels

netlify bot commented Nov 23, 2024 •

edited

Loading

✅ Deploy Preview for pytorch-fbgemm-docs ready!

Name	Link
🔨 Latest commit	`387e7e5`
🔍 Latest deploy log	https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67523e53da13bf000813ea56
😎 Deploy Preview	https://deploy-preview-3409--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Contributor

facebook-github-bot commented Nov 23, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

facebook-github-bot added the fb-exported label

q10 force-pushed the export-D66399304 branch from 7e38dff to 5b412a0 Compare

November 23, 2024 01:39

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

5b412a0

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Differential Revision: D66399304

Contributor

facebook-github-bot commented Nov 23, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

Contributor

avbokovoy commented Nov 25, 2024

Hi @q10. Consider cherry-picking 8cbcdff to get dense test pass

Contributor

facebook-github-bot commented Nov 25, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

005ab06

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 5b412a0 to 005ab06 Compare

November 25, 2024 19:38

Contributor

facebook-github-bot commented Nov 25, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

80384ca

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 005ab06 to 80384ca Compare

November 25, 2024 19:50

Contributor

facebook-github-bot commented Nov 27, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 80384ca to 207acc3 Compare

November 27, 2024 06:10

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

207acc3

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

1ac0710

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 207acc3 to 1ac0710 Compare

December 2, 2024 19:31

Contributor

facebook-github-bot commented Dec 2, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

1 similar comment

Contributor

facebook-github-bot commented Dec 2, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

bbb69c9

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 1ac0710 to bbb69c9 Compare

December 2, 2024 19:37

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

17b1cba

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from bbb69c9 to 17b1cba Compare

December 2, 2024 19:43

Contributor

facebook-github-bot commented Dec 2, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

1 similar comment

Contributor

facebook-github-bot commented Dec 4, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

e944f61

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 17b1cba to e944f61 Compare

December 4, 2024 00:12

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

52b6dd9

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from e944f61 to 52b6dd9 Compare

December 4, 2024 00:22

Contributor

facebook-github-bot commented Dec 4, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

a778623

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 52b6dd9 to a778623 Compare

December 4, 2024 00:37

Contributor

facebook-github-bot commented Dec 4, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304


          Optimzed backward pass for ROCm devices (pytorch#3367)

252944a

Summary:
Added optimized implementation of backward pass for ROCm devices. Currently support **not nobag** mode, **rowwise_adagrad** optimizer with non-mixed dimensions in [64, 128, 160, 192].

Pull Request resolved: pytorch#3367

Differential Revision: D66310520

Pulled By: leitian

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from a778623 to 9887d56 Compare

December 5, 2024 22:54

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

9887d56

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 9887d56 to 115c5ca Compare

December 5, 2024 23:08

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

115c5ca

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

2bfe7ce

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 115c5ca to 2bfe7ce Compare

December 5, 2024 23:14

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

3f37789

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 2bfe7ce to 3f37789 Compare

December 5, 2024 23:34

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304


          Patch D66310520 to make it build in OSS (pytorch#3409)

387e7e5

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 force-pushed the export-D66399304 branch from 3f37789 to 387e7e5 Compare

December 5, 2024 23:59

Contributor

facebook-github-bot commented Dec 5, 2024

This pull request was exported from Phabricator. Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

b6cc488

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

q10 added a commit to q10/FBGEMM that referenced this pull request


          Patch D66310520 to make it build in OSS (pytorch#3409)

3a0eb42

Summary:
Pull Request resolved: pytorch#3409

X-link: facebookresearch/FBGEMM#497

- Patch D66310520 to make the code build in OSS

Reviewed By: sryap

Differential Revision: D66399304

Contributor

facebook-github-bot commented Dec 16, 2024

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported module: rocm