Add check to ensure that there is enough room in permuted_indices #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D66274522 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zimin2000
pushed a commit
to zimin2000/FBGEMM
that referenced
this pull request
Nov 22, 2024
…torch#3403) Summary: In scope of the MTIA IG Sprint we encountered a crash (T208229934) that turned out to be an incorrectly provided argument for `permuted_lengths_sum` argument. This argument suppose to speed the operation, but actually, the true value it suppose to substitute is computed every time anyway. One radical solution would be to drop the argument entirely, but it requires more thoughtful analysis. This diff just prevent clearly faulty case of allocated `permuted_indices` being less than required by the function logic. Exactly this case was spotted in case of T208229934. Differential Revision: D66274522
zimin2000
force-pushed
the
export-D66274522
branch
from
feebfd0 to
27fea8d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66274522 |
zimin2000
pushed a commit
to zimin2000/FBGEMM
that referenced
this pull request
Nov 22, 2024
…torch#3403) Summary: In scope of the MTIA IG Sprint we encountered a crash (T208229934) that turned out to be an incorrectly provided argument for `permuted_lengths_sum` argument. This argument suppose to speed the operation, but actually, the true value it suppose to substitute is computed every time anyway. One radical solution would be to drop the argument entirely, but it requires more thoughtful analysis. This diff just prevent clearly faulty case of allocated `permuted_indices` being less than required by the function logic. Exactly this case was spotted in case of T208229934. Differential Revision: D66274522
zimin2000
force-pushed
the
export-D66274522
branch
from
27fea8d to
4b276d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66274522 |
added 2 commits
November 26, 2024 17:13
Differential Revision: D66012567
…torch#3403) Summary: X-link: facebookresearch/FBGEMM#493 In scope of the MTIA IG Sprint we encountered a crash (T208229934) that turned out to be an incorrectly provided argument for `permuted_lengths_sum` argument. This argument suppose to speed the operation, but actually, the true value it suppose to substitute is computed every time anyway. One radical solution would be to drop the argument entirely, but it requires more thoughtful analysis. This diff just prevent clearly faulty case of allocated `permuted_indices` being less than required by the function logic. Exactly this case was spotted in case of T208229934. Differential Revision: D66274522
zimin2000
force-pushed
the
export-D66274522
branch
from
4b276d5 to
bbe82f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66274522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In scope of the MTIA IG Sprint we encountered a crash (T208229934) that turned out to be an incorrectly provided argument for
permuted_lengths_sumargument.This argument suppose to speed the operation, but actually, the true value it suppose to substitute is computed every time anyway.
One radical solution would be to drop the argument entirely, but it requires more thoughtful analysis. This diff just prevent clearly faulty case of allocated
permuted_indicesbeing less than required by the function logic.Exactly this case was spotted in case of T208229934.
Differential Revision: D66274522