This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
bring back torch.autograd.Function for float8 matmul #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a redo of #316 With upcoming support of scaling granularities other than tensorwise, we need a good way to control which gemm kernel to call and how to scale the input tensors in fwd and bwd. A `torch.autograd.Function` override is the cleanest way to do that, and in 2024 this now works with `torch.compile`. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 26, 2024
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jul 26, 2024
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
|
This pull request has been merged in 345b3a5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This is a redo of
#316
With upcoming support of scaling granularities other than tensorwise,
we need a good way to control which gemm kernel to call and how to scale
the input tensors in fwd and bwd. A
torch.autograd.Functionoverrideis the cleanest way to do that, and in 2024 this now works with
torch.compile.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60291446