This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
[bc-breaking] rename TensorScalingType->ScalingType, Float8TensorCastConfig->CastConfig #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Config->CastConfig Summary: old: TensorScalingType, Float8TensorCastConfig new: ScalingType, CastConfig reason: make code more readable, previous names were too verbose, the `tensor` information is implied Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 25, 2024
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 25, 2024
weifengpy
approved these changes
Jul 25, 2024
…8TensorCastConfig->CastConfig" Summary: old: TensorScalingType, Float8TensorCastConfig new: ScalingType, CastConfig reason: make code more readable, previous names were too verbose, the `tensor` information is implied Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 0aca10a. |
vkuzo
added a commit
to pytorch/torchtitan
that referenced
this pull request
Jul 26, 2024
Summary: float8_experimental landed various BC-breaking UX changes last week. This PR updates torchtitan to work with the version of float8_experimental after pytorch-labs/float8_experimental#332 and pytorch-labs/float8_experimental#337 Test Plan: ``` with-proxy CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7 NGPU=8 CONFIG_FILE="./train_configs/llama3_8b.toml" ./run_llama_train.sh --training.enable_float8_linear --training.compile ``` Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Float8LinearConfig#334DelayedScalingRecipetoDelayedScalingConfig#333config.enable_fsdp_fp8_all_gatherto usefloat8#332Summary:
old: TensorScalingType, Float8TensorCastConfig
new: ScalingType, CastConfig
reason: make code more readable, previous names were too verbose, the
tensorinformation is impliedTest Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60252070