This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
fixes to matmul and linear benchmarks #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: for matmul benchmarks, unbreaks them - we need the scales to be fp32, not integers for linear benchmarks, aligns default settings to current best supported path (compile on, dynamic scaling) Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jul 17, 2024
Summary: for matmul benchmarks, unbreaks them - we need the scales to be fp32, not integers for linear benchmarks, aligns default settings to current best supported path (compile on, dynamic scaling) Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 49857da225d71615363e5bdeeb49bd8eecb212ef Pull Request resolved: #320
facebook-github-bot
added
the
CLA Signed
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 17, 2024
|
This pull request has been merged in ec8b46c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
for matmul benchmarks, unbreaks them - we need the scales to be fp32, not integers
for linear benchmarks, aligns default settings to current best supported path (compile on, dynamic scaling)
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59877198