This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
[not for land] enumerate breakages with module hooks + compile #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR rewrites Float8DynamicLinear to use module hooks, as we think long term this is more composable with other PyTorch features. For now there is no plan to land this, this is just reproducing / sharing what breaks when we try this today. Test Plan: ``` // note: all tests pass without this PR // eager mode is fine > pytest -s test/test_base.py | with-proxy gh gist create https://gist.github.com/vkuzo/aded224af91092c8326becc855b125c9 // compile has some errors in aot_eager backend > pytest -s test/test_compile.py | with-proxy gh gist create https://gist.github.com/vkuzo/cab55b11a2c3cee0d1ff94169131b171 // dtensor + float8 has numeric issues > ./test/test_dtensor.sh | with-proxy gh gist create https://gist.github.com/vkuzo/d1035200db22f2e3357438824cd3594f ``` Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
|
cc @bdhirsh |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR rewrites Float8DynamicLinear to use module hooks, as we think long term this is more composable with other PyTorch features. For now there is no plan to land this, this is just reproducing / sharing what breaks when we try this today.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: