This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
enumerate breakages of torch.compile + Float8Linear + FSDP/TP/SP #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This PR creates tests for composability of torch.compile + Float8Linear with: 1. FSDP - this works if we do torch.compile(FSDP(model)), and only apply torch.compile after the 1st iteration (lol) 2. TP/SP - torch.compile graph breaks on fairscale's RowParallelLinear/ColumnParallelLinear even without float8 (so it works but slow), and our float8 code currently crashes on graph breaks, so float8 + torch.compile + TP/SP is broken Test Plan: ``` ./test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR creates tests for composability of torch.compile + Float8Linear with:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: