Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for slow flamegraph rendering #392

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Workaround for slow flamegraph rendering #392

merged 2 commits into from
Jul 22, 2022

Conversation

itamarst
Copy link
Collaborator

Doesn't fix #390, but makes it better at least.

@github-actions
Copy link

Benchmark results

diff --git a/benchmarks/results/lots-of-peaks.json b/benchmarks/results/lots-of-peaks.json
index 383499f..54b4ac4 100644
--- a/benchmarks/results/lots-of-peaks.json
+++ b/benchmarks/results/lots-of-peaks.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"3771157 (188.06264867688517%)",-]{+"4748591 (210.84722680656392%)",+}
    "D1mw": [-"2763734 (1002.7001956474165%)",-]{+"3914404 (1379.4344136912155%)",+}
    "DLmr": [-"1492746 (2257.3344509639564%)",-]{+"2128504 (3604.3448196381237%)",+}
    "DLmw": [-"1858942 (1333.7673887649994%)",-]{+"2940618 (2053.3798326026304%)",+}
    "Dr": [-"231060633 (375.8621692938787%)",-]{+"210602938 (355.5532400495315%)",+}
    "Dw": [-"88001037 (338.04076205255154%)",-]{+"80000233 (323.2901030997181%)",+}
    "I1mr": [-"3555117 (1291.257363437142%)",-]{+"3863707 (1382.6562691923366%)",+}
    "ILmr": [-"14685 (224.7663551401869%)",-]{+"17585 (249.63410483321988%)",+}
    "Ir": [-"872039764 (403.39198904097907%)",-]{+"803852375 (382.78355848023403%)",+}
    "Overall": [-"1332452656 (406.55387644593173%)"-]{+"1297163564 (402.5398173069508%)"+}
}
diff --git a/benchmarks/results/multithreading-1.json b/benchmarks/results/multithreading-1.json
index 2d9d2d5..35bfadb 100644
--- a/benchmarks/results/multithreading-1.json
+++ b/benchmarks/results/multithreading-1.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"1866984 (413.64545831772375%)",-]{+"1858945 (411.9040468188705%)",+}
    "D1mw": [-"393456 (455.7661355950594%)",-]{+"393168 (455.6054014453298%)",+}
    "DLmr": [-"59324 (493.26483261518064%)",-]{+"58876 (486.4522481128979%)",+}
    "DLmw": [-"77459 (220.9427598913281%)",-]{+"78999 (223.60782963809046%)",+}
    "Dr": [-"77161209 (571.2328286082947%)",-]{+"62405178 (493.6363244709642%)",+}
    "Dw": [-"30820902 (440.2169730406361%)",-]{+"24749523 (388.7975207976146%)",+}
    "I1mr": [-"1638950 (586.5692113122628%)",-]{+"1652985 (586.4696637943213%)",+}
    "ILmr": [-"7958 (171.83607149304927%)",-]{+"8655 (177.4704618689581%)",+}
    "Ir": [-"254542209 (491.30873094686683%)",-]{+"213102045 (435.96543407633953%)",+}
    "Overall": [-"382464110 (492.83707107089475%)"-]{+"320273038 (438.02591214704705%)"+}
}
diff --git a/benchmarks/results/pystone.json b/benchmarks/results/pystone.json
index 3970408..764ea8b 100644
--- a/benchmarks/results/pystone.json
+++ b/benchmarks/results/pystone.json
@@ -1,12 +1,12 @@
{
    "D1mr": [-"4542966 (144.07376585255872%)",-]{+"6297481 (172.88836362554702%)",+}
    "D1mw": [-"1628141 (267.75567903740483%)",-]{+"869365 (162.2110351391289%)",+}
    "DLmr": [-"32802 (331.7507418397626%)",-]{+"32654 (328.78161563791775%)",+}
    "DLmw": [-"65725 (241.46577701248387%)",-]{+"66756 (243.96376967867155%)",+}
    "Dr": [-"367659717 (157.6310977517437%)",-]{+"301912091 (147.49473295617312%)",+}
    "Dw": [-"143586175 (159.9837295595579%)",-]{+"123184033 (151.86581541080648%)",+}
    "I1mr": [-"8784651 (214.74165578852526%)",-]{+"7840673 (204.372777443358%)",+}
    "ILmr": [-"7924 (170.99086185271457%)",-]{+"8499 (175.5399520042663%)",+}
    "Ir": [-"1160233461 (157.01681262908485%)",-]{+"1026850248 (150.5805305910022%)",+}
    "Overall": [-"1734495915 (158.00764418609307%)"-]{+"1515213718 (150.92017975812732%)"+}
}
diff --git a/benchmarks/results/version.txt b/benchmarks/results/version.txt
index d8f4897..9c2a20f 100644
--- a/benchmarks/results/version.txt
+++ b/benchmarks/results/version.txt
@@ -1 +1 @@
[-2021.9.2.dev9+gc3af8e6.d20211105-]{+2022.6.1.dev3+g7f0e920.d20220722+}

@itamarst itamarst merged commit ea078ac into master Jul 22, 2022
@itamarst itamarst deleted the 390-workaround branch July 22, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some flamegraphs are extremely slow to render
2 participants