Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pyright to v1.1.394 #13198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 5, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pyright ==1.1.389 -> ==1.1.394 age adoption passing confidence

Release Notes

RobertCraigie/pyright-python (pyright)

v1.1.394

Compare Source

v1.1.393

Compare Source

v1.1.392.post0

Compare Source

v1.1.392

Compare Source

v1.1.391

Compare Source

v1.1.390

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the bot: dependencies 🤖 Dependency file updates by renovate 🤖 label Dec 5, 2024
@JelleZijlstra
Copy link
Member

This seems like a new false positive:

/home/runner/work/typeshed/typeshed/stubs/icalendar/icalendar/__init__.pyi
  /home/runner/work/typeshed/typeshed/stubs/icalendar/icalendar/__init__.pyi:48:7 - error: "version" is declared as Final and cannot be reassigned (reportGeneralTypeIssues)
/home/runner/work/typeshed/typeshed/stubs/requests/requests/__init__.pyi
  /home/runner/work/typeshed/typeshed/stubs/requests/requests/__init__.pyi:2:7 - error: "__version__" is declared as Final and cannot be reassigned (reportGeneralTypeIssues)

Looking at the icalendar one:

  • icalendar/version.pyi has __version__: Final[str]
  • icalendar/__init__.pyi has from . version import __version__ as __version__
  • pyright complains about reassignment of the Final name

Will see if I can reproduce this in a self-contained package and then report to pyright.

@srittau
Copy link
Collaborator

srittau commented Dec 5, 2024

I think the problem are the following (simplified) statements:

from .version import version as version  # icalender
from .__version__ import __version__ as __version__  # requests

Technically speaking we're defining version twice in icalendar: The Final import from .version and then .version implicitly from the import. Still, considering that implicit imports are not supported in stub files (and are honestly an unfortunate design quirk at runtime), I'd rather wish we don't have to change our stubs.

@renovate renovate bot changed the title Update dependency pyright to v1.1.390 Update dependency pyright to v1.1.391 Dec 18, 2024
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch 2 times, most recently from 5affdd9 to 24d1dc9 Compare December 21, 2024 01:30
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 24d1dc9 to 281d6cf Compare January 1, 2025 00:51
@renovate renovate bot changed the title Update dependency pyright to v1.1.391 Update dependency pyright to v1.1.392 Jan 15, 2025
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 281d6cf to 7b95843 Compare January 15, 2025 13:18
@renovate renovate bot changed the title Update dependency pyright to v1.1.392 Update dependency pyright to v1.1.392.post0 Jan 15, 2025
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 7b95843 to 460d22e Compare January 15, 2025 17:10
@renovate renovate bot changed the title Update dependency pyright to v1.1.392.post0 Update dependency pyright to v1.1.393 Jan 29, 2025
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 460d22e to 7b0c960 Compare January 29, 2025 12:35
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 7b0c960 to 33170c6 Compare February 7, 2025 19:22
@renovate renovate bot changed the title Update dependency pyright to v1.1.393 Update dependency pyright to v1.1.394 Feb 12, 2025
@renovate renovate bot force-pushed the renovate/pytype-and-pyright branch from 33170c6 to c9c5ebc Compare February 12, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies 🤖 Dependency file updates by renovate 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants