[setuptools] Update to 74.1.* #12614
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'll do a proper review later. But just quickly letting you know that the msvc file was restored (with a few methods still pruned) in pypa/setuptools#4626 . So you can basically restore https://github.com/python/typeshed/pull/12599/files#diff-dd552d0277ca42b16d7514df0a75905ed71c607d1bb85c3d7c612b068cda330a , and remove the few extra methods stubtest should catch. |
I've stolen the sys.platform check from the old version, but that had a lot of |
This comment has been minimized.
This comment has been minimized.
| def microsoft(self, key: str, x86: bool = False) -> str: ... # type: ignore[misc] | ||
| def lookup(self, key: str, name: str) -> str: ... |
There was a problem hiding this comment.
These two can take a StrPath as the key param (and do represent relative paths, registry key paths to be exact).
But I'm pretty sure it's only meant to be a single final path segment, so relative Path support seem quite incidental. I think str is fine.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
--------- Co-authored-by: Avasam <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closes: #12613