Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final for distutils constants #12454

Merged
merged 9 commits into from
Aug 17, 2024
Merged

Final for distutils constants #12454

merged 9 commits into from
Aug 17, 2024

Conversation

max-muoto
Copy link
Contributor

@max-muoto max-muoto commented Jul 27, 2024 •
edited
Loading

This PR starts to use Final for the constants within disutils.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@max-muoto max-muoto marked this pull request as ready for review August 3, 2024 21:01
Avasam
Avasam requested changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@Avasam Avasam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few short literal constants that should be consistant across environments that we can specify explicitly (which makes them both Final and Literal).

Other than that small improvement it looks good to me.

stdlib/distutils/command/install.pyi Outdated Show resolved Hide resolved
stdlib/distutils/command/install_lib.pyi Outdated Show resolved Hide resolved
stdlib/distutils/cygwinccompiler.pyi Outdated Show resolved Hide resolved
stdlib/distutils/log.pyi Outdated Show resolved Hide resolved
stdlib/distutils/fancy_getopt.pyi Show resolved Hide resolved
stdlib/distutils/sysconfig.pyi Outdated Show resolved Hide resolved
@Avasam Avasam mentioned this pull request Aug 17, 2024
Merged
@max-muoto
Copy link
Contributor Author

@Avasam Appreciate the comprehensive review, comments addressed here: 3bc7f60

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam Avasam merged commit 30bbd86 into python:main Aug 17, 2024
63 checks passed
@Avasam
Copy link
Collaborator

Avasam commented Aug 17, 2024

Thanks !

max-muoto added a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
@max-muoto @Avasam @pre-commit-ci
Final for distutils constants (python#12454)
257b2fa 
Co-authored-by: Avasam <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam Avasam approved these changes

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-muoto @Avasam @srittau