Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkx: make Graph covariant #12288

Closed
wants to merge 1 commit into from
Closed

networkx: make Graph covariant #12288

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 6, 2024

Close #12186

Copy link
Contributor

github-actions bot commented Jul 6, 2024

Diff from mypy_primer, showing the effect of this PR on open source code:

bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:
+ src/bokeh/models/util/structure.py:165: note: ... from here:

@sobolevn
Copy link
Member Author

sobolevn commented Jul 7, 2024

This looks a lot more complex as I initially thought.

@sobolevn sobolevn closed this Jul 7, 2024
@AlexWaygood AlexWaygood deleted the issue-12186 branch July 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[networkx] Cannot assign concrete types to Graph[Hashable]
1 participant