-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pep-0557.rst: typos, .. code:: python directives #488
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
pep-0557.rst
Outdated
@@ -186,10 +194,10 @@ signature. That is, these three uses of ``@dataclass`` are equivalent:: | |||
|
|||
The parameters to ``dataclass`` are: | |||
|
|||
- ``init``: If true (the default), a ``__init__`` method will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always read these as "a dunder init method", so the original sounds correct to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough.
I've already signed the CLA. And now I've added my github username to the bpo account. |
I don't see any uses of "code:: python" in any existing PEP, so I'm not inclined to start using it here. |
Meanwhile, I've fixed the two typos with extra s's that you noted. Thanks. |
No other PEPs have language directives because we have not had Pygments installed on www.python.org. I know someone was trying to make that happen, but I don't know where that ended up. |
In python/pythondotorg#1063 (comment) it was said that we'll be moving to Sphinx/Readthedocs so we won't be adding Pygments. |
I'm guessing this isn't going to be merged, so closing. |
Just baffling how this occurs.
If I had to guess? Prolly 2-3 years before we get syntax highlighting on
these bad boys
…On Saturday, July 7, 2018, Guido van Rossum ***@***.***> wrote:
Closed #488 <#488>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#488 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AADGyzFZpk-2To8vKup3lEa-o6n5bEblks5uETuXgaJpZM4QwZU4>
.
|
That was a real helpful comment, Wes. |
@ericvsmith