Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 752: Address feedback, round 5 #4018

Merged
merged 5 commits into from
Nov 15, 2024
Merged

PEP 752: Address feedback, round 5 #4018

merged 5 commits into from
Nov 15, 2024

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 3, 2024 •
edited
Loading

  1. Added more instances of documented feedback.
  2. Rejected the idea of exclusively relying on digital attestations.
  3. Rejected the idea of adding new dependency syntax for asserting the name of project owners.
  4. Made explicit the earlier rejected the idea of artifact-level namespace association.
  5. Removed part of a footnote upon request.

📚 Documentation preview 📚: https://pep-previews--4018.org.readthedocs.build/

@ofek ofek requested a review from warsaw as a code owner October 3, 2024 18:41
warsaw
warsaw approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions about phrasing, but otherwise LGTM. Feel free to fix/reject and merge.

willingc
willingc approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ofek. I suggested some wording in response to @warsaw's comments.

willingc
willingc reviewed Oct 6, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ofek.

@hugovk hugovk merged commit 5795f7b into python:main Nov 15, 2024
6 checks passed
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@ofek @willingc @gvanrossum
PEP 752: Address feedback, round 5 (python#4018)
13426bf 
Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@warsaw warsaw warsaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofek @warsaw @willingc @hugovk