-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 757: use PyLong_Export #3970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Sep 17, 2024
vstinner
reviewed
Sep 17, 2024
skirpichev
commented
Sep 17, 2024
Co-authored-by: Victor Stinner <[email protected]>
vstinner
reviewed
Sep 17, 2024
* minor edits (fix section header, etc) * redo example, assuming that for compact integers - value set
vstinner
reviewed
Sep 17, 2024
vstinner
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This version is maybe not perfect, but it's a great step forward for smaller integers (IMO). I merged your PR, thanks. I'm not sure if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes
)This change export API to Antoine Pitrou -like proposal.
value
or store here absolute value.value
field for future use.📚 Documentation preview 📚: https://pep-previews--3970.org.readthedocs.build/