Convert 12 PEPs #187
Merged
Convert 12 PEPs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 211 PEP 218 PEP 223 - fix couple typos: 'discussed' and 'incompatibility' - add reference to a python-dev discussion titled 'Go \x yourself' PEP 243 PEP 244 PEP 265 PEP 278 PEP 279 PEP 337 PEP 356 PEP 379 PEP 3144
brettcannon
requested changes
Jan 23, 2017
| non-restartable inner iterators and cache their values. | ||
| 3. There would have to be some way to distinguish restartable | ||
| iterators from ones that couldn't be restarted. For example, | ||
| if ``S`` is an input stream (e.g. a file), and ``L`` is a list, then ``S |
There was a problem hiding this comment.
Does having a literal spanning lines render properly?
There was a problem hiding this comment.
Renders fine :) see attached screenshot:
| I believe the most common case would actually be ``by_value=1, | ||
| reversed=1``, but the defaults values given here might lead to | ||
| fewer surprises by users: ``sorted_items()`` would be the same as | ||
| ``items()`` followed by ``sort()```. |
There was a problem hiding this comment.
Will remove in the next commit.
| reversed=1", but the defaults values given here might lead to | ||
| fewer surprises by users: sorted_items() would be the same as | ||
| items() followed by sort(). | ||
| I believe the most common case would actually be ``by_value=1, |
There was a problem hiding this comment.
In case multi-line literals are a problem.
There was a problem hiding this comment.
Here's how it looks like (after I removed the extra backticks at the end)
| @@ -1,203 +1,227 @@ | |||
| PEP: 279 | |||
| Title: The enumerate() built-in function | |||
| Title: The ``enumerate()`` built-in function | |||
There was a problem hiding this comment.
No need for the backticks in the title.
PEP 279, remove backticks from title
brettcannon
approved these changes
Jan 24, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 211
PEP 218
PEP 223
PEP 243
PEP 244
PEP 265
PEP 278
PEP 279
PEP 337
PEP 356
PEP 379
PEP 3144
Ongoing work for #4