-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert 10 PEPs to reSt #180
Conversation
PEP 212 PEP 216 PEP 219 PEP 228 PEP 235 PEP 269 PEP 288 PEP 312 PEP 315 PEP 3102
add indices() and irange() to built-ins[4] | ||
add items() method to listobject[5] | ||
- 'for i indexing a in l': exposing the for-loop counter [3]_ | ||
- add ``indices()`` and ``irange()`` to built-ins [4]_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using ``...`` formatting consistently (or don't use it at all) CONSTANTs and function()s aren't the only things that can be wrapped by ``...``. If you change irange() to ``irange()``, I'd expect the following sentence to be formatted too:
This solution adds two built-in functions 'indices' and 'irange'.
I guess you have a script that converts these PEPs to reST format, but It would be nice to do some proofreading before sending a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, @Mariatta has written a script to do the conversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think a moderate amount of proofreading and manual fix-up is warranted, I don't think the formatting needs to be perfect. We're mostly trying to improve the rendering of old historical documents, and if occasionally something isn't using a code font that is code, that's fine with me. Someone else can do some proofreading. The most important thing is that we don't accidentally break the meaning of a PEP.
Thanks for the review, @berkerpeksag @brettcannon and @gvanrossum :) I've gone through these again, and made these changes:
Please let me know if you notice anything else that needs adjustment. |
Since you already address the backtick request from @berkerpeksag and I'm with Guido that as long as the content's meaning doesn't shift I'm not too worried about minor formatting, I'm merging this. Thanks @Mariatta ! |
Thanks :) |
Here are some additional comments:
d558317 and e511fb5 should address some of these comments, but the last one still needs to be fixed. |
Sorry that I did not notice these mistakes before, and thanks for fixing them @berkerpeksag
Any suggestion on how to fix this? i.e.
|
I don't think keeping the references for pointing to specific bullet points is critical. If you would use an explanatory shorthand that does the same thing, e.g. "The second rule is the same rule ..." |
PEP 212
PEP 216
PEP 219
PEP 228
PEP 235
PEP 269
PEP 288
PEP 312
PEP 315
PEP 3102
#4