Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #38 #116

Merged
merged 5 commits into from
Oct 15, 2016
Merged

Closes #38 #116

merged 5 commits into from
Oct 15, 2016

Conversation

warsaw
Copy link
Member

@warsaw warsaw commented Oct 13, 2016

No description provided.

@warsaw
Copy link
Member Author

warsaw commented Oct 13, 2016

See what you think about these changes. I am trying to steer people to GitHub for most things, but leave peps@ around for semi-private discussions when needed (hopefully rarely!).

The standard PEP workflow is:

* You, the PEP author, clones the `PEP repository`_, and create a file named
`pep-xxxx.rst` that contains your new PEP. Use "XXX" as your draft PEP
Copy link
Member

@berkerpeksag berkerpeksag Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep-xxxx.rst or pep-0xxx.rst

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, python.org's PEP importer doesn't notice the .rst extension at the moment. I'm planning to fix it this weekend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the markup fix. I'll apply that and push it.

As for .rst - should I change it to .txt or keep it know that you're going to make it all better? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like the .rst extension to work so that PEPs render nicely in the GitHub UI: #1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this because of python.org. I'd say keep it as-is. I've already wrote the code so I just need a couple of hours to write a unit test and cleanup the code :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we'll keep .rst then.

authors are not Python committers yet, so PEP editors do the commits for them.
Updates to existing PEPs should be submitted as a `GitHub pull request`_.
Questions may of course still be sent to <[email protected]>. Many PEP authors
are not Python committers yet, so PEP editors do the commits for them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the last sentence since we don't commit their updates for them anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


The standard PEP workflow is:

* You, the PEP author, clones the `PEP repository`_, and create a file named
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typical GitHub terminology here would be to "fork the PEP repository on GitHub"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncoghlan I was sticking with git terminology, but I'm okay with using GitHub terminology. Just don't even get me started between "pull requests" and "merge requests"!

* You, the PEP author, clones the `PEP repository`_, and create a file named
``pep-0xxx.rst`` that contains your new PEP. Use "XXX" as your draft PEP
number.
* Push this to your GitHub clone and submit a pull request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/clone/fork

email in a timely manner, the PEP editors will make a unilateral
decision (it's not like such decisions can't be reversed :).
If you are interested in assuming ownership of a PEP, you can also do this via
pull request. Clone the git repository, make your ownership modification, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/clone/fork/

Use GitHub terminology rather than generic git terminology.
@ncoghlan ncoghlan merged commit 1cdddf8 into master Oct 15, 2016
@ncoghlan
Copy link
Contributor

I figured it made sense to go ahead and merge this, since it's already more accurate than what we had previously, and any further fixes can just go in a new PR

@warsaw warsaw deleted the issue38 branch October 15, 2016 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants