Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename functional.py to _functional.py #306

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Rename functional.py to _functional.py #306

merged 1 commit into from
Jun 26, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 22, 2024

Should this module be private or should importing from importlib_resources.functional be allowed?

Your call :)

Fixes: #305

@encukou
Copy link
Member Author

encukou commented Mar 28, 2024

I plan to update the CPython PR next week, and include this rename there.

FFY00
FFY00 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change and giving the lack of movement on the issue an PR, I am gonna go ahead and approve it.

@FFY00 FFY00 merged commit 0058f32 into python:main Jun 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 FFY00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make functional module private
2 participants
@encukou @FFY00