Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make functional module private #305

Closed
jaraco opened this issue Mar 22, 2024 · 2 comments · Fixed by #306
Closed

Make functional module private #305

jaraco opened this issue Mar 22, 2024 · 2 comments · Fixed by #306

Comments

@jaraco
Copy link
Member

jaraco commented Mar 22, 2024

Should this module be private or should importing from importlib_resources.functional be allowed?

Originally posted by @layday in #303 (comment)

@FFY00
Copy link
Member

FFY00 commented Jun 26, 2024

I don't think it should be allowed, that's more exposed API without a real need IMO.

@layday
Copy link

layday commented Jun 26, 2024

This appears to have already been done in the stdlib BTW: https://github.com/python/cpython/blob/main/Lib/importlib/resources/_functional.py. I don't know if any other differences exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants