gh-131798: JIT: Optimize _CALL_LEN when the length is known #135260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Jun 8, 2025
Comment on lines
+1195
to
+1207
| int tuple_length = sym_tuple_length(arg); | ||
| if (tuple_length >= 0) { | ||
| PyObject *temp = PyLong_FromLong(tuple_length); | ||
| if (temp == NULL) { | ||
| goto error; | ||
| } | ||
| if (_Py_IsImmortal(temp)) { | ||
| REPLACE_OP(this_instr, _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW, | ||
| 0, (uintptr_t)temp); | ||
| } | ||
| res = sym_new_const(ctx, temp); | ||
| Py_DECREF(temp); | ||
| } |
There was a problem hiding this comment.
This is basically copied from the recent _GET_LEN optimization
brandtbucher
approved these changes
Jun 9, 2025
|
I'm planning to merge this once the tests pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same principle as #135194 to completely remove
_CALL_LENwhen the length is known.I don't know how common it is to actually know the length exactly so please let me know if this is not worth it, but given that
_CALL_LENis the most common builtin call, it felt worth to optimize this case.