GH-91079: Implement C stack limits using addresses, not counters. #130007
+1,204
−1,448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m independent constants
markshannon
requested review from
rhettinger,
a team,
encukou,
Eclips4,
isidentical,
JelleZijlstra,
pablogsal,
lysnikolaou,
ericsnowcurrently,
iritkatriel and
carljm
as code owners
iritkatriel
reviewed
Feb 14, 2025
| @@ -112,7 +112,10 @@ struct _ts { | |||
| int py_recursion_remaining; | |||
| int py_recursion_limit; | |||
|
|
|||
| int c_recursion_remaining; | |||
| // These are addresses, but we need to convert to ints to avoid UB. | |||
Comment on lines
+635
to
+645
| def raises_syntax_or_memory_error(txt): | ||
| try: | ||
| eval(txt) | ||
| self.fail("No exception raised") | ||
| except SyntaxError: | ||
| pass | ||
| except MemoryError: | ||
| pass | ||
| except Exception as ex: | ||
| self.fail(f"Should raise SyntaxError or MemoryError, not {type(ex)}") | ||
|
|
There was a problem hiding this comment.
Suggested change
| def raises_syntax_or_memory_error(txt): | |
| try: | |
| eval(txt) | |
| self.fail("No exception raised") | |
| except SyntaxError: | |
| pass | |
| except MemoryError: | |
| pass | |
| except Exception as ex: | |
| self.fail(f"Should raise SyntaxError or MemoryError, not {type(ex)}") | |
| def raises_syntax_or_memory_error(txt): | |
| try: | |
| eval(txt) | |
| except (SyntaxError, MemoryError): | |
| pass | |
| except Exception as ex: | |
| self.fail(f"Should raise SyntaxError or MemoryError, not {type(ex)}") | |
| else: | |
| self.fail("No exception raised") |
There was a problem hiding this comment.
Otherwise the exception raised from self.fail is handled in the except Exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this will also fix #113655.