Feat: Add vendor_generic_rust_package helper #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vendor_generic_rust_package` function is a generic version of `vendor_rust` function. The existing function deals with Python packaging. The generic function works with any Rust package. The new function is needed for `wandb`, which builds a Rust program, not a Python extension. Signed-off-by: Christian Heimes <[email protected]>
rd4398
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vendor_generic_rust_packagefunction is a generic version ofvendor_rustfunction. The existing function deals with Python packaging. The generic function works with any Rust package.The new function is needed for
wandb, which builds a Rust program, not a Python extension.