Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bootstrapping from git checkouts of projects #551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhellmann
Copy link
Member

Support git+https URLs in the input requirements list.

"Resolve" the version by cloning the repo at the specified reference and
generating the metadata to extract the version string.

Rely on the git clone instead of downloading a source distribution or
allowing an override to specify where the source should come from.

Rely on the git clone with preparing source, and ignore any overrides.

Force sdists to be generated using the PEP-517 approach.

Add e2e tests for cases with and without tags in the URLs.

@dhellmann dhellmann force-pushed the bootstrap-git-urls branch 2 times, most recently from 506c967 to fb00b2b Compare February 22, 2025 21:35
Copy link
Contributor

@rd4398 rd4398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few comments which are mostly for my clarification. Overall, this looks good! I would leave it to @tiran and / or @paradigm for final review and approval.

Support git+https URLs in the input requirements list.

"Resolve" the version by cloning the repo at the specified reference and
generating the metadata to extract the version string.

Rely on the git clone instead of downloading a source distribution or
allowing an override to specify where the source should come from.

Rely on the git clone with preparing source, and ignore any overrides.

Force sdists to be generated using the PEP-517 approach.

Add e2e tests for cases with and without tags in the URLs.

Signed-off-by: Doug Hellmann <[email protected]>
@dhellmann dhellmann requested a review from rd4398 February 25, 2025 21:43
Copy link
Contributor

@rd4398 rd4398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants