-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bootstrapping from git checkouts of projects #551
Open
dhellmann
wants to merge
1
commit into
python-wheel-build:main
Choose a base branch
from
dhellmann:bootstrap-git-urls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
506c967
to
fb00b2b
Compare
rd4398
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fb00b2b
to
3773074
Compare
Support git+https URLs in the input requirements list. "Resolve" the version by cloning the repo at the specified reference and generating the metadata to extract the version string. Rely on the git clone instead of downloading a source distribution or allowing an override to specify where the source should come from. Rely on the git clone with preparing source, and ignore any overrides. Force sdists to be generated using the PEP-517 approach. Add e2e tests for cases with and without tags in the URLs. Signed-off-by: Doug Hellmann <[email protected]>
3773074
to
6a0165a
Compare
rd4398
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
tiran
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support git+https URLs in the input requirements list.
"Resolve" the version by cloning the repo at the specified reference and
generating the metadata to extract the version string.
Rely on the git clone instead of downloading a source distribution or
allowing an override to specify where the source should come from.
Rely on the git clone with preparing source, and ignore any overrides.
Force sdists to be generated using the PEP-517 approach.
Add e2e tests for cases with and without tags in the URLs.