Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prebuilt-wheel hook #536

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tiran
Copy link
Collaborator

@tiran tiran commented Jan 22, 2025

The prebuilt_wheel hook complements the post_build hook. While the post build hook runs after a wheel has been built, the prebuilt wheel hook runs after a wheel has been downloaded. The new hook makes it possible to upload prebuilt wheels to an internal Python index.

Fixes: #535

@mergify mergify bot added the ci label Jan 22, 2025
@tiran tiran force-pushed the prebuilt-wheel-hook branch 2 times, most recently from 607d431 to 2997e3f Compare January 23, 2025 11:01
The `prebuilt_wheel` hook complements the `post_build` hook. While the
post build hook runs after a wheel has been built, the prebuilt wheel
hook runs after a wheel has been downloaded. The new hook makes it
possible to upload prebuilt wheels to an internal Python index.

Fixes: python-wheel-build#535
Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran force-pushed the prebuilt-wheel-hook branch from 2997e3f to 3634fa2 Compare January 23, 2025 11:11
@mergify mergify bot added the mergify label Jan 23, 2025
@tiran tiran marked this pull request as ready for review January 23, 2025 11:21
@tiran tiran requested a review from dhellmann January 23, 2025 15:50
Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the test case.

@mergify mergify bot merged commit e6f94c9 into python-wheel-build:main Jan 23, 2025
78 checks passed
@tiran tiran deleted the prebuilt-wheel-hook branch January 24, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fromager.hooks for pre-built wheels
2 participants