Fix vendor Rust: limit to manifests from backend #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to verify the changes with cryptography 42, 43, and 44. |
|
Looks like a ci failure |
tiran
force-pushed
the
better-vendor-rust
branch
from
a0c23b1 to
eec7e9c
Compare
|
I have successfully built |
tiran
force-pushed
the
better-vendor-rust
branch
3 times, most recently
from
90a8b75 to
53daee5
Compare
Fromager was vendoring crates from all `Cargo.toml` files in a project. This approach is causing issues for projects that have cargo files in tests and example directories. The `vendor_rust()` function now only vendors crates from `Cargo.toml` in the project's root directory and additional cargo files listed in `tools.maturin` or `tools.setuptools-rust` entries. Fixes: python-wheel-build#529 Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
better-vendor-rust
branch
from
53daee5 to
28c0d57
Compare
|
it'd be great to get this merged - its been working for me on the PR checked out |
Excellent, I was just waiting to hear back from you and then it fell off of the top of my todo list. |
dhellmann
approved these changes
Feb 5, 2025
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
Released in 0.38.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fromager was vendoring crates from all
Cargo.tomlfiles in a project. This approach is causing issues for projects that have cargo files in tests and example directories.The
vendor_rust()function now only vendors crates fromCargo.tomlin the project's root directory and additional cargo files listed intools.maturinortools.setuptools-rustentries.Fixes: #529