Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Duplicates are written to constraints file during bootstrapping #525

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Bug Fix: Duplicates are written to constraints file during bootstrapping #525

merged 1 commit into from
Dec 11, 2024

Conversation

rd4398
Copy link
Contributor

@rd4398 rd4398 commented Dec 10, 2024

Fixes : #524

@mergify mergify bot added the ci label Dec 10, 2024
@rd4398
Copy link
Contributor Author

rd4398 commented Dec 10, 2024

  • I am getting into an infinite loop while trying to set resolved_something = True. Check line # 256
  • Also, need help to figure out part to use existing package versions to pick the "right" version of item for multiple version case

dhellmann
dhellmann reviewed Dec 10, 2024
View reviewed changes
@rd4398 rd4398 marked this pull request as ready for review December 11, 2024 20:36
dhellmann
dhellmann reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, but this is looking good.

@mergify mergify bot merged commit 67a0a4e into python-wheel-build:main Dec 11, 2024
74 checks passed
@shubhbapna
Copy link
Collaborator

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann approved these changes

@shubhbapna shubhbapna Awaiting requested review from shubhbapna

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Duplicates are written to constraints file during bootstrapping
3 participants
@rd4398 @shubhbapna @dhellmann