ensure packages with common prefixes do not mix patches #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a problem introduced in python-wheel-build#488 that could cause packages with a prefix common to another package's full name to have their patches included when scanning for patches of the package with the shorter name. For example, with patches for both 'foo' and 'foo-bar' when patches for 'foo' are loaded they would have included patches for 'foo-bar'.
tiran
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem introduced in #488 that could cause packages with a prefix
common to another package's full name to have their patches included
when scanning for patches of the package with the shorter name. For
example, with patches for both 'foo' and 'foo-bar' when patches for
'foo' are loaded they would have included patches for 'foo-bar'.