Use keyword-only args for API functions #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import API functions no longer accept positional arguments and only support keyword arguments. This makes the code more reliable, readable, and prepares the functions for the `timeit` decorator. Related: python-wheel-build#408 Related: python-wheel-build#445 Signed-off-by: Christian Heimes <[email protected]>
shubhbapna
reviewed
Oct 2, 2024
There was a problem hiding this comment.
LGTM, but will wait for @dhellmann review since this is a breaking change
dhellmann
reviewed
Oct 2, 2024
I think now is good. I don't see a new fromager release landing downstream while we have code freeze. Worst case if we do a need a release with a specific bug fix we create a branch of the 0.31 tag |
dhellmann
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import API functions no longer accept positional arguments and only support keyword arguments. This makes the code more reliable, readable, and prepares the functions for the
timeitdecorator.Related: #408
Related: #445