Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript template #2071

Merged

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Jan 3, 2025

One too many semi-colons. Closes #2070.

@hansthen hansthen requested a review from Conengmo January 3, 2025 18:16
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for looking into this.

Man we really need better tests...

@hansthen
Copy link
Collaborator Author

hansthen commented Jan 4, 2025

Let's make that our number one goal for 2025 to improve our test coverage.

@hansthen hansthen merged commit 29062dd into python-visualization:main Jan 4, 2025
11 checks passed
Conengmo pushed a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline and TimelineSlider example code does not work
2 participants